Re: [PATCH] staging: rtl8723bs: remove unnecessary comparison to true

[Nikolay Kulikov]

On Sun, May 03, 2026 at 06:40:53PM +0530, Ashwin Gundarapu wrote:
> Remove unnecessary comparison to true in conditional statement.
> Found by checkpatch.
> 
> Signed-off-by: Ashwin Gundarapu <ashwin.gundarapu@xxxxxxxxx>
> ---

> From b49d621579be96ef71e3206b888f3ab39c297491 Mon Sep 17 00:00:00 2001
> From: Ashwin Gundarapu <ashwin.gundarapu@xxxxxxxxx>
> Date: Sat, 2 May 2026 17:19:48 +0530
> Subject: [PATCH] staging: rtl8723bs: remove unnecessary comparison to true
> 
> Remove explicit comparison to true in check_fwstate() call and
> add spacing around the bitwise OR operator to improve code style.
> 
> Signed-off-by: Ashwin Gundarapu <ashwin.gundarapu@xxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> index c70541f95a73..c100a0d70fe2 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> @@ -151,7 +151,8 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct ndis_802_11_ssid *ssid)
>  	else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) == true)
>  		goto release_mlme_lock;
>  
> -	if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) == true) {
> +	if (check_fwstate(pmlmepriv,
> +		_FW_LINKED | WIFI_ADHOC_MASTER_STATE)) {
>  		if ((pmlmepriv->assoc_ssid.ssid_length == ssid->ssid_length) &&
>  		    (!memcmp(&pmlmepriv->assoc_ssid.ssid, ssid->ssid, ssid->ssid_length))) {
>  			if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) == false) {
> -- 
> 2.43.0
> 

Hello,

Your patch arrived as an attachment, not in the body of the email. The
kernel development process requires patches to be in the body of the
email so they can be viewed and quoted in replies.

Please resend it using "git send-email'.
See Documentation/process/submitting-patches.rst and [1] for more
information.

[1] https://kernelnewbies.org/FirstKernelPatch


Thanks,
Nikolay