Re: [PATCH] isa: switch to dynamic root device

[Danilo Krummrich]

On Sun May 3, 2026 at 7:08 AM CEST, William Breathitt Gray wrote:
> Would you resend with a Fixes tag

Devices should generally be allocated dynamically for various reasons (e.g. I
recently had a case where adding a dynamic lock class key to struct device for
debugging purposes caused warnings for all the static devices).

While it clearly should be improved, I don't think this causes a bug in the ISA
code -- there is no "real" leak as the device is static anyway and there's no
spurious WARN() as release() is never hit, since ISA is always built-in.

I'd assume this is why Johan did not add it in the first place.

That said, if you mean to add a Fixes: tag anyway to indicate the technically
wrong usage pattern of struct device, that seems reasonable to me.