Re: [PATCH 0/5] watchdog: dw_wdt: reset clean up and pm

[Guenter Roeck]

Hi,

On 3/20/26 06:56, Artem Shimko wrote:
> Hello maintainers and reviewers,
>
> Patch 1 moves reset_control_deassert() before any register access to
> ensure the watchdog controller is properly taken out of reset before
> configuration, fixing a potential hardware access issue.
>
> Patch 2 adds proper error handling for reset_control_deassert() to
> prevent probe from continuing when reset deassertion fails, improving
> diagnostics and reliability.
>
> Patch 3 replaces manual reset control management with the
> devm_reset_control_get_optional_shared_deasserted() helper, eliminating
> explicit reset_control_assert() calls in error paths and remove.
>
> Patch 4 adds reset line management during system suspend and resume,
> asserting the reset before clocks are disabled and deasserting after
> clocks are re-enabled to maintain consistent hardware state.
>
> Patch 5 is a final cleanup of the resume function error handling.
>
> Thank you!

Please check the AI review feedback at

https://sashiko.dev/#/patchset/20260320135624.223863-1-a.shimko.dev%40gmail.com

and address the concerns.

Thanks,
Guenter