Re: [PATCH v2 3/4] arm64: dts: qcom: hamoa-pmics: define VADC for pmk8550

[Aleksandrs Vinarskis]

On Friday, April 17th, 2026 at 07:27, Jishnu Prakash <jishnu.prakash@xxxxxxxxxxxxxxxx> wrote:

> On 4/4/2026 6:25 PM, Aleksandrs Vinarskis wrote:
> > Follow pattern of pmk8350 to add missing pmk8550 VADC to hamoa.
> > Register address of 0x9000 matches example schema for spmi-adc5-gen3.
> >
> > Signed-off-by: Aleksandrs Vinarskis <alex@xxxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/hamoa-pmics.dtsi | 26 ++++++++++++++++++++++++++
> >  1 file changed, 26 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/hamoa-pmics.dtsi b/arch/arm64/boot/dts/qcom/hamoa-pmics.dtsi
> > index 6a31a0adf8be472badea502a916cdbc9477e9f2b..cc69d299bc356d90aa1483f347f5eee43b853e45 100644
> > --- a/arch/arm64/boot/dts/qcom/hamoa-pmics.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/hamoa-pmics.dtsi
> > @@ -218,6 +218,32 @@ pon_resin: resin {
> >  			};
> >  		};
> >
> > +		pmk8550_vadc: adc@9000 {
> > +			compatible = "qcom,spmi-adc5-gen3";
> > +			reg = <0x9000>, <0x9100>;
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			interrupts = <0x0 0x90 0x1 IRQ_TYPE_EDGE_RISING>,
> > +				     <0x0 0x91 0x1 IRQ_TYPE_EDGE_RISING>;
> > +			#io-channel-cells = <1>;
> > +			#thermal-sensor-cells = <1>;
> > +
> > +			channel@3 {
> > +				reg = <0x3>;
> > +				label = "pmk8550_die_temp";
> > +				qcom,pre-scaling = <1 1>;
> > +			};
> > +
> > +			channel@44 {
> > +				reg = <0x44>;
> > +				label = "pmk8550_xo_therm";
> > +				qcom,pre-scaling = <1 1>;
> > +				qcom,ratiometric;
> > +				qcom,hw-settle-time = <200>;
> > +				qcom,adc-tm;
>
> There's a small problem here - if you add the "qcom,adc-tm" property
> under any channels, the auxiliary TM driver will be loaded to handle
> this functionality and it will attempt to register such channels as
> thermal devices. Since there is no thermal-zone node added for this
> channel, you will get an error from here.
>
> If you intend this channel to be used for ADC_TM functionality, a
> thermal zone node for this channel has to be added. If this functionality
> is not needed, it's better to remove the "qcom,adc-tm" property.

Thanks for catching this, I did not realize it. It would be nice to add
thermal zone node in the future, currently I am missing required
information to do that. For now I will drop "qcom,adc-tm" property as
you suggested.

Alex

>
> Thanks,
> Jishnu
>
> > +			};
> > +		};
> > +
> >  		pmk8550_rtc: rtc@6100 {
> >  			compatible = "qcom,pmk8350-rtc";
> >  			reg = <0x6100>, <0x6200>;
> >
>
>