Re: [PATCH v2 2/2] regulator: add SGM3804 Dual Output driver

From: Neil Armstrong

Date: Mon May 04 2026 - 02:59:17 EST


On 5/1/26 01:46, Mark Brown wrote:
On Thu, Apr 30, 2026 at 03:28:43PM +0200, Neil Armstrong wrote:
On 4/30/26 12:34, Mark Brown wrote:
On Thu, Apr 30, 2026 at 10:48:47AM +0200, Neil Armstrong wrote:

+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * SGMicro SGM3804 regulator Driver
+ *
+ * Copyright (C) 2025 Kancy Joe <kancy2333@xxxxxxxxxxx>
+ * Copyright (C) 2026 Linaro Limited
+ * Author: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
+ */

Please make the entire comment block a C++ one so things look more
intentional.

Sure, converted into:
+ * Copyright (C) 2026 Linaro Limited (Neil Armstrong <neil.armstrong@xxxxxxxxxx>)

That's not the issue - that's not converting into a C++ comment.

Oh right sorry I was confused, and I'm still very confused, sure I'll convert it
to C++ comment block even if I don't fully understand the rationale about it and
how does this look more intentional.

Do you want me to also switch _all_ comments to C++ style ?

Neil