Re: [PATCH v2 2/2] drivers: dio: use tabs and avoid continuation logging in dio_init

[Geert Uytterhoeven]

Hi Thorsten,

On Mon, 4 May 2026 at 10:18, Thorsten Blum <thorsten.blum@xxxxxxxxx> wrote:
> Indent multiple lines using tabs instead of spaces. Use pr_info() and
> avoid continuation logging.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
i.e. will queue in the m68k tree for v7.2.

> --- a/drivers/dio/dio.c
> +++ b/drivers/dio/dio.c

> @@ -248,17 +248,18 @@ static int __init dio_init(void)
>
>                 dev->ipl = DIO_IPL(va);
>                 strscpy(dev->name, dio_getname(dev->id));
> -                printk(KERN_INFO "select code %3d: ipl %d: ID %02X", dev->scode, dev->ipl, prid);
>                 if (DIO_NEEDSSECID(prid))
> -                        printk(":%02X", secid);
> -                printk(": %s\n", dev->name);
> +                       pr_info("select code %3d: ipl %d: ID %02X:%02X: %s\n",
> +                               dev->scode, dev->ipl, prid, secid, dev->name);
> +               else
> +                       pr_info("select code %3d: ipl %d: ID %02X: %s\n",
> +                               dev->scode, dev->ipl, prid, dev->name);

I'll change these "%d" to print dev->ipl to "%u" while applying.

>
>                 if (scode >= DIOII_SCBASE)
>                         iounmap(va);

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds