RE: [PATCH net-next 12/15] ice: access @pp through netmem_desc instead of page

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Keller, Jacob E <jacob.e.keller@xxxxxxxxx>
> Sent: Friday, May 1, 2026 8:37 AM
> To: Kitszel, Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>; Andrew Lunn
> <andrew+netdev@xxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric
> Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo
> Abeni <pabeni@xxxxxxxxxx>; Lobakin, Aleksander
> <aleksander.lobakin@xxxxxxxxx>; Simon Horman <horms@xxxxxxxxxx>;
> Michal Swiatkowski <michal.swiatkowski@xxxxxxxxxxxxxxx>; Jagielski,
> Jedrzej <jedrzej.jagielski@xxxxxxxxx>; Loktionov, Aleksandr
> <aleksandr.loktionov@xxxxxxxxx>; Nitka, Grzegorz
> <grzegorz.nitka@xxxxxxxxx>; Vecera, Ivan <ivecera@xxxxxxxxxx>;
> Kubalewski, Arkadiusz <arkadiusz.kubalewski@xxxxxxxxx>; Nguyen,
> Anthony L <anthony.l.nguyen@xxxxxxxxx>; Wegrzyn, Stefan
> <stefan.wegrzyn@xxxxxxxxx>
> Cc: Kwapulinski, Piotr <piotr.kwapulinski@xxxxxxxxx>;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Keller, Jacob E
> <jacob.e.keller@xxxxxxxxx>; Byungchul Park <byungchul@xxxxxx>; Nowlin,
> Alexander <alexander.nowlin@xxxxxxxxx>; Rinitha, SX
> <sx.rinitha@xxxxxxxxx>; David Hildenbrand (Arm) <david@xxxxxxxxxx>
> Subject: [PATCH net-next 12/15] ice: access @pp through netmem_desc
> instead of page
> 
> From: Byungchul Park <byungchul@xxxxxx>
> 
> To eliminate the use of struct page in page pool, the page pool users
> should use netmem descriptor and APIs instead.
> 
> Make ice driver access @pp through netmem_desc instead of page.
> 
> Signed-off-by: Byungchul Park <byungchul@xxxxxx>
> Tested-by: Alexander Nowlin <alexander.nowlin@xxxxxxxxx>
> Tested-by: Rinitha S <sx.rinitha@xxxxxxxxx>
> Reviewed-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>
> Signed-off-by: Jacob Keller <jacob.e.keller@xxxxxxxxx>
> ---
>  drivers/net/ethernet/intel/ice/ice_ethtool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c
> b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> index f28416a707d7..236d293aba98 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
> +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> @@ -1251,7 +1251,7 @@ static int ice_lbtest_receive_frames(struct
> ice_rx_ring *rx_ring)
>  		rx_buf = &rx_ring->rx_fqes[i];
>  		page = __netmem_to_page(rx_buf->netmem);
>  		received_buf = page_address(page) + rx_buf->offset +
> -			       page->pp->p.offset;
> +			       pp_page_to_nmdesc(page)->pp->p.offset;
> 
>  		if (ice_lbtest_check_frame(received_buf))
>  			valid_frames++;
> 
> --
> 2.54.0.rc2.531.gaf818d63126a

Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>