Re: [PATCH net-next 5/5] dt-bindings: net: Add bindings for the ADIN1140

[Andrew Lunn]

> > > +        ethernet@0 {
> > > +            compatible = "adi,adin1140";
> > > +            reg = <0>;
> > > +            spi-max-frequency = <23000000>;
> > > +
> > > +            interrupt-parent = <&gpio>;
> > > +            interrupts = <6 IRQ_TYPE_EDGE_FALLING>;
> > 
> > Table 1: OPEN serial 10BASE-T1x Interface Pin Definition
> > 
> > IRQn MAC-PHY Interrupt Request (Active Low)
> > 
> > Or is this something else which the device gets wrong?
> 
> The device generates interrupts correctly (the IRQ signal remains
> asserted while there are active interrupt conditions that have not
> been cleared yet). The oa_tc6 driver requests the interrupt with
> the IRQF_TRIGGER_FALLING flag set

Ah, that is a bug in oa_tc6.c. A falling edge appears to work, until
it does not and then all interrupts stop. So bugs like this are not
obvious. I've been looking out for this more over the last few years
since PHYs are level, not edge, but many developers get them wrong in
DT.

Please could you submit a patch to net to fix this?

       Andrew