Re: [PATCH v5 13/13] arm64: dts: qcom: eliza: Add power-domain and iface clk for ice node

[Konrad Dybcio]

On 4/21/26 11:38 AM, Kuldeep Singh wrote:
> On 16-04-2026 17:29, Harshal Dev wrote:
>> Qualcomm in-line crypto engine (ICE) platform driver specifies and votes
>> for its own resources. Before accessing ICE hardware during probe, to
>> avoid potential unclocked register access issues (when clk_ignore_unused
>> is not passed on the kernel command line), in addition to the 'core' clock
>> the 'iface' clock should also be turned on by the driver. This can only be
>> done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the
>> GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for
>> eliza.
>>
>> Fixes: af20af39fc09b ("arm64: dts: qcom: Introduce Eliza Soc base dtsi")
> 
> On thing I noticed in entire patchseries,
> https://docs.kernel.org/process/submitting-patches.html
> """
> If your patch fixes a bug in a specific commit, e.g. you found an issue using git bisect, please use the ‘Fixes:’ tag with at least the first 12 characters of the SHA-1 ID, and the one line summary. Do not split the tag across multiple lines, tags are exempt from the “wrap at 75 columns” rule in order to simplify parsing scripts. For example:
> 
> Fixes: 54a4f0239f2e ("KVM: MMU: make kvm_mmu_zap_page() return the number of pages it actually freed")
> """
> 
> Fixes tag need atleast 12 chars and I see other submissions specifying 12 chars whereas this series specify 13 chars.
> Not sure if there's some hard rule on this.

I think the general idea is "the more the merrier", although 12 has
been the standard for the longest time

see:

https://lore.kernel.org/lkml/cover.1733421037.git.geert+renesas@xxxxxxxxx/
https://people.kernel.org/kees/colliding-with-the-sha-prefix-of-linuxs-initial-git-commit

Konrad