Re: [PATCH v5 1/2] scripts: generate_rust_analyzer.py: add versioning infrastructure

From: Jesung Yang

Date: Mon May 04 2026 - 09:25:16 EST


On Sun, May 3, 2026 at 10:21 PM Tamir Duberstein <tamird@xxxxxxxxxx> wrote:
>
> Indeed. Codex figured it out:
>
> The cause is your global Git config. You have:
>
> git config --show-origin --get log.follow
> # file:/Users/tamird/.gitconfig true
>
> That affects /Users/tamird/code/check.sh:9: with a single pathspec,
> git log ... -- src/tools/rust-analyzer behaves as if --follow was
> passed. In this non-linear subtree history, --follow drops the merge
> commits, so the grep for Merge pull request # finds nothing.
>
> Best script fix: make that command immune to user config, e.g. add
> --no-follow or use git -c log.follow=false -C ./rust log ....
>
> Secondary issue: after this is fixed, macOS /bin/bash here is 3.2 and
> does not have readarray, so /Users/tamird/code/check.sh:12 will hit
> another portability failure on this machine.
>
> Mind incorporating these fixes in the next version?

Happy to :)

(Surprised macOS is still on bash from 2006... I suppose it has
something to do with the GPLv3 transition.)

Best regards,
Jesung