Re: [PATCH 01/15] serial: 8250: split Moxa PCIe serial board support out of 8250_pci

[Andy Shevchenko]

On Mon, May 4, 2026 at 4:27 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Mon, May 4, 2026 at 11:49 AM Crescent Hsieh
> <crescentcy.hsieh@xxxxxxxx> wrote:

...

> > +static void mxpcie8250_remove(struct pci_dev *pdev)
> > +{
> > +       struct mxpcie8250 *priv = dev_get_drvdata(&pdev->dev);
>
> platform_get_drvdata() IIRC

Note, for the sake of consistency the probe may use platform_set_drvdata().

> > +       unsigned int i;
> > +
> > +       for (i = 0; i < priv->num_ports; i++)
>
> As per above.
>
> > +               serial8250_unregister_port(priv->line[i]);
> > +}

-- 
With Best Regards,
Andy Shevchenko