Re: [PATCH v3 2/2] regulator: add SGM3804 Dual Output driver

[Mark Brown]

On Mon, May 04, 2026 at 02:44:06PM +0200, Neil Armstrong wrote:

>  obj-$(CONFIG_REGULATOR_SUN20I) += sun20i-regulator.o
> +obj-$(CONFIG_REGULATOR_SGM3804) += sgm3804-regulator.o

The sorting is off here (and in Kconfig).

> +err:
> +	gpiod_set_value(ctx->gpios[rdev_get_id(rdev)], 0);
> +	return ret;

A stray gpiod_set_value() here.

Attachment: signature.asc
Description: PGP signature