Re: [PATCH v2 18/53] objtool/klp: Simplify reloc symbol conversion

From: Miroslav Benes

Date: Mon May 04 2026 - 10:14:04 EST


On Thu, 30 Apr 2026 21:08:06 -0700, Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> Inline section_reference_needed() and is_reloc_allowed() into
> convert_reloc_sym() and remove the redundant is_reloc_allowed() check in
> clone_reloc().
>
> Move the is_sec_sym() checks into the convert callees so they become
> no-ops when the reloc is already in the right format. This allows
> convert_reloc_sym() to unconditionally dispatch to the right converter
> based on section type.
>
> [...]

Reviewed-by: Miroslav Benes <mbenes@xxxxxxx>

--
Miroslav