Re: [PATCH 2/2] platform/x86: asus-armoury: downgrade missing power limits warning to info

[Mario Limonciello]

On 5/4/26 02:27, Armandas Kvietkus wrote:
> [You don't often get email from armundunelis@xxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> When a system is not found in the power_limits DMI table,
> init_rog_tunables() emits a pr_warn() and returns. This is
> expected behaviour for hardware that does not support ROG
> power limit tunables, not an error condition.
>
> Downgrade to pr_info() to avoid spurious boot noise on
> unsupported systems while keeping the message visible in
> default distro configurations.
>
> v2: use pr_info() instead of pr_debug() to ensure the message
>      remains visible without dynamic debug (Denis Benato)
>
> Reported-by: fxzxaxon@xxxxxxxxxxx
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221441
> Signed-off-by: Armandas Kvietkus <armundunelis@xxxxxxxxx>
> ---

I thought the whole point of this message was so that the limits could 
be looked up and reported.

If anything I would argue there should be more added to this message 
telling people to come file a bug report to the appropriate place to get 
the limits determined and added.

>   drivers/platform/x86/asus-armoury.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
> index 5b0987ccc..b87e0b601 100644
> --- a/drivers/platform/x86/asus-armoury.c
> +++ b/drivers/platform/x86/asus-armoury.c
> @@ -991,7 +991,7 @@ static void init_rog_tunables(void)
>          /* Match the system against the power_limits table */
>          dmi_id = dmi_first_match(power_limits);
>          if (!dmi_id) {
> -               pr_warn("No matching power limits found for this system\n");
> +               pr_info("No matching power limits found for this system\n");
>                  return;
>          }
>
> --
> 2.54.0