Re: [PATCH] staging: greybus: add missing newline to sysfs_emit

From: Greg KH

Date: Mon May 04 2026 - 10:59:59 EST


On Tue, Apr 28, 2026 at 04:57:08PM +0000, Ajith P V wrote:
> The sysfs attribute is missing a terminating newline.
> According to the kernel documentation for sysfs, attributes should
> be terminated by a newline to follow standard userspace conventions.
>
> Fix the formatting by adding a '\n' to the sysfs_emit string.
> This resolves the checkpatch warning:
> "return sysfs_emit(...) formats should include a terminating newline"
>
> Signed-off-by: Ajith P V <ajithpv.linux@xxxxxxxxx>
> ---
> drivers/staging/greybus/audio_manager_module.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You sent a patch that has been sent multiple times in the past few
days, and is identical to ones that has been recently rejected.
Please always look at the mailing list traffic to determine if you are
duplicating other people's work.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot