Re: [PATCH v2] staging: greybus: uart: clear unsupported c_cflag bits in set_termios
From: Greg KH
Date: Mon May 04 2026 - 11:01:00 EST
On Mon, Apr 27, 2026 at 10:24:46AM +0530, Debjeet Banerjee wrote:
> gb_tty_set_termios() derives UART line configuration from a subset of
> termios->c_cflag bits (CSIZE, CSTOPB, PARENB, PARODD, CMSPAR, CRTSCTS,
> CLOCAL and CBAUD). Other bits are not interpreted by the driver and are
> not represented in the Greybus UART protocol.
>
> Mask unsupported c_cflag bits so that userspace-visible termios
> reflects the supported bits implemented by the driver.
>
> This addresses the existing FIXME.
>
> Signed-off-by: Debjeet Banerjee <debjeetbanerjee48@xxxxxxxxx>
> ---
> v2:
> - Clear unsupported c_cflag bits as suggested
> - Update comment to mention the change
Has this been tested? If not, I'd prefer to leave this as-is until it
can be.
thanks,
greg k-h