Re: [PATCH v4 1/4] arm64: dts: qcom: monaco-evk: Extract common EVK hardware into shared dtsi

[Umang Chheda]

Hello Konrad,

Thanks for reviewing the patch

On 5/4/2026 6:27 PM, Konrad Dybcio wrote:
> On 4/27/26 7:05 PM, Umang Chheda wrote:
>> The monaco-ac EVK is a new board variant which shares the majority of
>> its hardware description with the existing monaco-evk board.
>>
>> In preparation for adding this variant, extract the common hardware
>> nodes from monaco-evk.dts into a new shared monaco-evk-common.dtsi
>> include file, and update monaco-evk.dts to include it and keep only
>> board-specific overrides.
>>
>> No functional change intended.
>>
>> Signed-off-by: Umang Chheda <umang.chheda@xxxxxxxxxxxxxxxx>
>> ---
> 
> The patch is a bit difficult to view as-is, but the gist of it is that
> the resulting monaco-evk.dts is:
> 
> // SPDX-License-Identifier: BSD-3-Clause
> /*
>  * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
>  */
> 
> /dts-v1/;
> 
> #include "monaco-evk-common.dtsi"
> 
> / {
> 	model = "Qualcomm Technologies, Inc. Monaco EVK";
> 	compatible = "qcom,monaco-evk", "qcom,qcs8300";
> 
> 	/* This comes from a PMIC handled within the SAIL domain */
> 	vreg_s2s: vreg-s2s {
> 		compatible = "regulator-fixed";
> 		regulator-name = "vreg_s2s";
> 
> 		regulator-min-microvolt = <1800000>;
> 		regulator-max-microvolt = <1800000>;
> 	};
> };
> 
> &sdhc_1 {
> 	vmmc-supply = <&vreg_l8a>;
> 	vqmmc-supply = <&vreg_s2s>;
> 
> 	no-sd;
> 	no-sdio;
> 	non-removable;
> 
> 	status = "okay";
> };
> 
> 
> which begs the question - is the eMMC only there on the non-AC SKU?

AC SKU as well has eMMC - though it uses another power rail. Currently
changes are not yet ready for the AC SKU hence haven't added the support
yet. will raise another patch - once it's ready.

> 
> Konrad

Thanks,
Umang