Re: [PATCH RFC v2 3/6] arm64: dts: qcom: sm8550-qrd: add SPMI ADC channels and thermal nodes

[Dmitry Baryshkov]

On Mon, May 04, 2026 at 06:29:51PM +0200, Neil Armstrong wrote:
> Add the SPMI ADC channels on the PMK8550 SPMI5 ADC3 for the
> other PMICS on the system.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 279 ++++++++++++++++++++++++++++++++
>  1 file changed, 279 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
> index 2fb2e0be5e4c..8405cb9e0d6d 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
> @@ -17,6 +17,9 @@
>  #include "pmk8550.dtsi"
>  #include "pmr735d_a.dtsi"
>  #include "pmr735d_b.dtsi"
> +#include "qcom,pm8550-adc5-gen3.h"
> +#include "qcom,pm8550b-adc5-gen3.h"
> +#include "qcom,pm8550vx-adc5-gen3.h"
>  
>  / {
>  	model = "Qualcomm Technologies, Inc. SM8550 QRD";
> @@ -205,6 +208,92 @@ platform {
>  		};
>  	};
>  
> +	thermal-zones {
> +		skin-thermal {
> +			thermal-sensors = <&pmk8550_vadc PM8550_ADC5_GEN3_AMUX_THM1_100K_PU(1)>;
> +
> +			trips {
> +				active-config0 {
> +					temperature = <125000>;
> +					hysteresis = <1000>;
> +					type = "passive";
> +				};
> +			};
> +		};
> +
> +		cam-flash-thermal {

Nit: I understand that the nodes are sorted by the sensor channel rather
than the name. Would it make sense to add a note (here or in the commit
message)?

> 

-- 
With best wishes
Dmitry