RE: [PATCH v2] EDAC/altera: Fix SDMMC PortB OF node reference leak

[Zhuo, Qiuxu]

> From: Yuho Choi <dbgh9129@xxxxxxxxx>
> Sent: Monday, May 4, 2026 5:26 AM
> To: Dinh Nguyen <dinguyen@xxxxxxxxxx>; Borislav Petkov <bp@xxxxxxxxx>;
> Luck, Tony <tony.luck@xxxxxxxxx>
> Cc: linux-edac@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Yuho Choi
> <dbgh9129@xxxxxxxxx>
> Subject: [PATCH v2] EDAC/altera: Fix SDMMC PortB OF node reference leak
> 
> of_find_compatible_node() returns a device node with its refcount
> incremented. altr_portb_setup() looks up the SDMMC ECC node but does not
> drop that reference on error paths or after successful setup.
> 
> Route those exits through an of_node_put() cleanup path. Also free the EDAC
> control info if devres_open_group() fails after dci has been allocated, and
> release the devres group before freeing dci because altdev is stored in dci-
> >pvt_info.
> 
> Fixes: 911049845d70 ("EDAC, altera: Add Arria10 SD-MMC EDAC support")
> Signed-off-by: Yuho Choi <dbgh9129@xxxxxxxxx>
> ---
> Changes since v1:
> - Free the EDAC control info when devres_open_group() fails after dci
>   has been allocated.
> - Release the PortB devres group before freeing dci so altdev->ddev
>   remains valid during devres cleanup.
> - Keep the !dci failure path limited to dropping the OF node reference.
> 
>  drivers/edac/altera_edac.c | 17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)


LGTM. Thanks.

   Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>