Re: [PATCH v2 4/4] phy: qcom: qmp-usbc: Add qmp configuration for Shikra

[Krishna Kurapati]

On 5/5/2026 12:58 AM, Dmitry Baryshkov wrote:
> On Mon, May 04, 2026 at 10:36:59PM +0530, Krishna Kurapati wrote:
> > Add init sequence and phy configuration for the Super Speed port
> > on Shikra SoC.
> >
> > Signed-off-by: Krishna Kurapati <krishna.kurapati@xxxxxxxxxxxxxxxx>
> > ---
> >   drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c b/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
> > index c342479a3798..400dcebf8222 100644
> > --- a/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
> > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
> > @@ -2019,6 +2019,9 @@ static const struct of_device_id qmp_usbc_of_match_table[] = {
> >   	}, {
> >   		.compatible = "qcom,sdm660-qmp-usb3-phy",
> >   		.data = &sdm660_usb3phy_cfg,
> > +	}, {
> > +		.compatible = "qcom,shikra-qmp-usb3-phy",
> > +		.data = &qcs615_usb3phy_cfg,
>
> If we are reusing Talos configuration, should Talos also be used for the
> fallback compat instead of modifying the driver?

The clocks are different and hence I didn't use fallback.

Regards,
Krishna,

> >   	}, {
> >   		.compatible = "qcom,sm6115-qmp-usb3-phy",
> >   		.data = &qcm2290_usb3phy_cfg,
> > --
> > 2.34.1