Re: [PATCH v3 0/4] i2c: designware: Improve device disable handling

From: Andy Shevchenko

Date: Tue May 05 2026 - 03:36:07 EST


On Mon, May 04, 2026 at 08:15:01PM +0000, William A. Kennington III wrote:
> When the I2C master attempts a new transaction while the slave
> controller is shutting down or restarting, it can lead to bus lockups
> and system bootloops if the hardware enters an inconsistent state.
>
> This patch series addresses this by ensuring that the internal state
> machines are properly cleared when disabling the controller if slave
> activity is detected.
>
> Additionally, it adds a shutdown hook that gracefully sets the slave
> disable bit before disabling the controller. This guarantees that any
> incoming requests from the master are immediately NACKed during
> shutdown, preventing the bus from hanging.

In general series looks good, just some style issues, see individual replies.
If you address them as suggested, I will give my tag against v4.

--
With Best Regards,
Andy Shevchenko