Re: [PATCH v1] mtd: rawnand: fix condition in 'nand_select_target()'

From: Miquel Raynal

Date: Tue May 05 2026 - 04:25:41 EST



On 05/05/2026 at 11:14:25 +03, Arseniy Krasnov <avkrasnov@xxxxxxxxx> wrote:

> 05.05.2026 11:10, Miquel Raynal wrote:
>> On 05/05/2026 at 10:59:16 +03, Arseniy Krasnov <avkrasnov@xxxxxxxxx> wrote:
>>
>>> 05.05.2026 10:50, Miquel Raynal wrote:
>>>> Hi,
>>>>
>>>> On 05/05/2026 at 01:10:12 +03, Arseniy Krasnov <avkrasnov@xxxxxxxxx> wrote:
>>>>
>>>> Two important typos in the commit log :-)
>>>>
>>>>> 'cs' here must in range [0:nanddev_ntargets).
>>>> be [
>>>
>>> Hi, sorry, You mean?
>>>
>>>
>>> 'cs' here must be in range [0:nanddev_ntargets]. 
>> I meant [0:nanddev_ntargets[ which is the mathematical way, IIRC, to
>> indicate that the last value is out of scope/excluded.
>>
>> [0:nanddev_ntargets] means that nanddev_ntargets is included in the
>> scope of values and here since you are explicitly showing that it is
>> not, it feels wrong to use that convention.
>
>
> Ahh, Yes I see, just small misunderstood in math symbols:
>
> I mean: [A:B) == [A:B[
>
> https://wikimedia.org/api/rest_v1/media/math/render/svg/0719b1b08cdf649e735e6dab6dc7355fa37a9b21

Ah ok, didn't know that other convention, fine then, take the one you prefer if
both are identical. Just add the missing "be" please!

Thanks,
Miquèl