Re: [PATCH] rust: io: convert `PhysAddr` type alias to newtype
From: Albab Hasan
Date: Tue May 05 2026 - 05:22:10 EST
Thanks for pointing it out. I'm extremely sorry. i always seem to miss
previously submitted patches.
I'll take on another issue and take a look at the other patch.
Thanks
On Tue, 5 May 2026 at 04:08, Danilo Krummrich <dakr@xxxxxxxxxx> wrote:
>
> Hi Albab,
>
> On Mon May 4, 2026 at 6:57 AM CEST, Albab Hasan wrote:
> > Makes `PhysAddr` a newtype wrapper around `bindings::phys_addr_t`.
> > This restricts what operations are possible with physical address
> > values, helping prevent mistakes such as mixing them with other
> > integer quantities.
> >
> > Arithmetic operations are intentionally not provided; none of the
> > current users perform address arithmetic in Rust.
> >
> > Suggested-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
> > Link: https://github.com/Rust-for-Linux/linux/issues/1204
> > Signed-off-by: Albab Hasan <albabhasan276@xxxxxxxxx>
>
> Thanks for the patch; a similar patch [1] has already been submitted slightly
> before this one.
>
> May I suggest picking up another issue and / or help reviewing the other patch
> in [1]?
>
> Thanks,
> Danilo
>
> [1] https://lore.kernel.org/driver-core/20260503103050.200526-1-x@xxxxxxx/