Re: [PATCH v2 19/53] objtool/klp: Fix pointer comparisons for rodata objects

From: Miroslav Benes

Date: Tue May 05 2026 - 05:45:49 EST


On Thu, 30 Apr 2026 21:08:07 -0700, Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> klp-diff treats all rodata as uncorrelated, so any reference to it uses
> a duplicated copy rather than using a KLP reloc.
>
> For the contents of the data itself, a duplicated copy is fine.
> However, pointer comparisons (e.g., f->f_op == &foo_ops) are broken.
>
> Fix it by correlating non-anonymous rodata objects.
>
> [...]

Reviewed-by: Miroslav Benes <mbenes@xxxxxxx>

--
Miroslav