Re: [PATCH v3] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2)

[Ilpo Järvinen]

On Fri, 1 May 2026, Haichen Feng wrote:

> Sorry for write wrong patch. It is my mistake. This patch move 8BC2 to 
> the front of 8BCA. 

Hi,

Thanks for the update but here you should describe the change. This text 
will be directly taken as the commit message of the resulting commit, so 
think of reviewers of your patch and those reading kernel's commit history 
later and write to those audiences.

I think the previous version had better text here (but this is based on my 
memory, I didn't actually go to fetch v2 from archives).

> Signed-off-by: Haichen Feng <2806891994@xxxxxx>
> ---
> Change in v3:
>  - Move 8BC2 to the front of 8BCA

If you want to have extra explanation about the process that got you here 
which should be put into the commit message, the place for such text is 
after the --- line like you have tha patch changelog (correctly) here.

-- 
 i.

> ---
>  drivers/platform/x86/hp/hp-wmi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
> index d1cc6e7d1..a5cda787c 100644
> --- a/drivers/platform/x86/hp/hp-wmi.c
> +++ b/drivers/platform/x86/hp/hp-wmi.c
> @@ -205,6 +205,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
>  		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BBE") },
>  		.driver_data = (void *)&victus_s_thermal_params,
>  	},
> +	{
> +		.matches = {DMI_MATCH(DMI_BOARD_NAME, "8BC2")},
> +		.driver_data = (void *)&omen_v1_thermal_params,
> +	},
>  	{
>  		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BCA") },
>  		.driver_data = (void *)&omen_v1_thermal_params,
>