Re: [PATCH v5 1/2] drm/atomic: attempt full modeset on page flip timeout

From: Hamza Mahfooz

Date: Tue May 05 2026 - 07:50:29 EST


On Mon, May 04, 2026 at 04:50:21PM -0500, Mario Limonciello wrote:
> Do you actually need to set all 3 of these to true?
>
> I would think you only need:
>
> crtc_state->mode_changed = true;
>

According to my testing `mode_changed` on it's own is sufficient for
amdgpu and the documentation [1] seems to suggest that it should be fine
more broadly. Though, it doesn't seem harmful to set all of them just
for safe measure.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/drm/drm_crtc.h?h=v7.1-rc2#n118