Re: [PATCH v4 7/8] iio: light: si1133: add local variable for timeout

[Jonathan Cameron]

On Mon, 4 May 2026 12:03:08 +0300
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:

> On Mon, May 04, 2026 at 10:59:21AM +0200, Joshua Crofts wrote:
> > On Mon, 4 May 2026 at 10:53, Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxx> wrote:  
> > > On Thu, Apr 30, 2026 at 05:04:27PM +0200, Joshua Crofts via B4 Relay wrote:
> > >  
> > > > Add local variable for timeout to improve readability.
> > > >
> > > > No functional change.  
> > >
> > > Hmm... I am not sure about this as previously it was one jump and now two jumps
> > > over the code to get the actual value of the timeout. OTOH, I don't care much
> > > in this case.  
> > 
> > This was actually a suggestion by Jonathan, as the original indentation
> > of the function parameters was horrible, so it was better to just add it as
> > a variable to improve readability. Perhaps I should've added a suggested-by tag.  
> 
> You added it, and I have seen that. Still my opinion stays. Of course, it's up to
> Jonathan to make the final decision.
> 
No need to assign the value at declaration. If that's right next to the use
then I think everyone is happy.