Re: [PATCH v4 2/5] MAINTAINERS: iio: adi: consolidate entries

[Andy Shevchenko]

On Tue, May 05, 2026 at 11:54:09AM +0100, Jonathan Cameron wrote:
> On Tue, 5 May 2026 12:04:40 +0300
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:
> > On Tue, May 05, 2026 at 08:00:23AM +0530, Sanjay Chitroda wrote:
> > > On 4 May 2026 9:54:57 pm IST, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:  
> > > >On Fri,  1 May 2026 00:36:39 +0530
> > > >Sanjay Chitroda <sanjayembeddedse@xxxxxxxxx> wrote:  

...

> > > >> -AD738X ADC DRIVER (AD7380/1/2/4)
> > > >> -M:	Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> > > >> -M:	Nuno Sá <nuno.sa@xxxxxxxxxx>  
> > > >Specific maintainer. Why is it going?  
> > > 
> > > I'm assuming that to avoid de-bounce issues from *@analog.com domain, we are
> > > adding linux@xxxxxxxxxx mailing list as primary contact. with that in mind,
> > > this series drops all entries which match the wildcard and have analog domain
> > > maintainer or reviewer while keeping the rest as unchanged.  
> > 
> > But it's removing people behind their will! You really should do this
> > case-by-case. Some of the people who left the company might still want to
> > follow the driver or even maintain it. What you should do is also pay attention
> > on the Supported vs. Maintained which makes a huge difference on the
> > responsibility and financial side of the Subject.
> 
> Some of this was in response to discussion with on specific person.
> That one is fine but be very careful beyond that.
> Probably best to add a link tag back to that discussion as well.

Or at least mentioning this in the commit message / cover letter.

> > Btw, Have you consulted with your Legal department on all this?
> > 
> > > >> -R:	David Lechner <dlechner@xxxxxxxxxxxx>  
> > > 
> > > Additionally, When David is list as reviewer in individual driver entries, I
> > > consider as redundant part; All IIO subsystem drivers/iio* already covered by
> > > top level entry, which includes Andy and David as reviewer.
> > > 
> > > Summary of changes in series:
> > > - analog domain specific entries are dropped and catch with linux@xxxxxxxxxx
> > > under ADI IIO section.  
> > 
> > No, you should give a good explanation why in each case. Yes, you may combine
> > the cases when people left the company, but you also need to
> > - consult with your Legal
> > - consult with those who left on what they wish
> > 
> > None of them seems done so far. So, again BIG NAK from me on this series!
> > Rework them and even part that drops the entries that already have the same
> > maintainers as current ADI level ones (assuming adding Nuno in a separate
> > prerequisite patch) is good to go.
> 
> I'm not keen on using the top level reviewers as enough to drop an entry.
> Where Nuno and David have specific driver entries the lifetime of those
> may well be different to the top level one.  So leave those alone.

True, but if the people who maintain the certain driver(s) are okay with the
collapse, why not allow that?

> The only ones I don't mind falling back to the top level catch alls are
> those where we are dropping a reviewer / maintainer (and they were asked)
> + there is nothing else listed - hence the higher level entry is the
> only source of information.
> 
> A wider scrub is not appropriate.
> 
> > > - Non analog devices reviewers and maintainer is unchanged for each driver entry.
> > > 
> > > Further, I also agree with adding Nuno Sá as a maintainer in the top-level
> > > ADI IIO entry, so that all drivers are maintained via the mailing list with
> > > his oversight.
> > >   
> > > >> -S:	Supported
> > > >> -W:	https://wiki.analog.com/resources/tools-software/linux-drivers/iio-adc/ad738x
> > > >> -W:	https://ez.analog.com/linux-software-drivers
> > > >> -F:	Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml
> > > >> -F:	Documentation/iio/ad7380.rst
> > > >> -F:	drivers/iio/adc/ad7380.c  

-- 
With Best Regards,
Andy Shevchenko