Re: [PATCH] dt-bindings: hwmon: zyxel,nsa320-mcu: convert to DT schema

[Guenter Roeck]

On Fri, May 01, 2026 at 10:21:16AM +0000, Manish Baing wrote:
> Convert the ZyXEL NSA320 MCU bindings from text format to YAML schema.
> 
> Signed-off-by: Manish Baing <manishbaing2789@xxxxxxxxx>
> Acked-by: Adam Baker <linux@xxxxxxxxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Applied, after fixing Acked-By: -> Acked-by: as above.

Thanks,
Guenter

> ---
>  .../devicetree/bindings/hwmon/nsa320-mcu.txt  | 20 -------
>  .../bindings/hwmon/zyxel,nsa320-mcu.yaml      | 54 +++++++++++++++++++
>  2 files changed, 54 insertions(+), 20 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/nsa320-mcu.txt
>  create mode 100644 Documentation/devicetree/bindings/hwmon/zyxel,nsa320-mcu.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/nsa320-mcu.txt b/Documentation/devicetree/bindings/hwmon/nsa320-mcu.txt
> deleted file mode 100644
> index 0863e067c85b..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/nsa320-mcu.txt
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -Bindings for the fan / temperature monitor microcontroller used on
> -the Zyxel NSA 320 and several subsequent models.
> -
> -Required properties:
> -- compatible	: "zyxel,nsa320-mcu"
> -- data-gpios	: The GPIO pin connected to the data line on the MCU
> -- clk-gpios	: The GPIO pin connected to the clock line on the MCU
> -- act-gpios	: The GPIO pin connected to the active line on the MCU
> -
> -Example:
> -
> -	hwmon {
> -		compatible = "zyxel,nsa320-mcu";
> -		pinctrl-0 = <&pmx_mcu_data &pmx_mcu_clk &pmx_mcu_act>;
> -		pinctrl-names = "default";
> -
> -		data-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
> -		clk-gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
> -		act-gpios = <&gpio0 17 GPIO_ACTIVE_LOW>;
> -	};
> diff --git a/Documentation/devicetree/bindings/hwmon/zyxel,nsa320-mcu.yaml b/Documentation/devicetree/bindings/hwmon/zyxel,nsa320-mcu.yaml
> new file mode 100644
> index 000000000000..a111f8125e09
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/zyxel,nsa320-mcu.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/zyxel,nsa320-mcu.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ZyXEL NSA320 MCU
> +
> +maintainers:
> +  - Adam Baker <linux@xxxxxxxxxxxxxxxx>
> +  - Guenter Roeck <linux@xxxxxxxxxxxx>
> +
> +description:
> +  The ZyXEL NSA320 uses a dedicated microcontroller to manage system-critical
> +  functions like fan speed and power monitoring. It is connected to the SoC
> +  via a GPIO-based serial protocol.
> +
> +properties:
> +  compatible:
> +    const: zyxel,nsa320-mcu
> +
> +  data-gpios:
> +    maxItems: 1
> +    description: GPIO pin connected to the data line on the MCU.
> +
> +  clk-gpios:
> +    maxItems: 1
> +    description: GPIO pin connected to the clock line on the MCU.
> +
> +  act-gpios:
> +    maxItems: 1
> +    description: GPIO pin connected to the active line on the MCU.
> +
> +required:
> +  - compatible
> +  - data-gpios
> +  - clk-gpios
> +  - act-gpios
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    hwmon {
> +        compatible = "zyxel,nsa320-mcu";
> +        pinctrl-0 = <&pmx_mcu_data &pmx_mcu_clk &pmx_mcu_act>;
> +        pinctrl-names = "default";
> +
> +        data-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
> +        clk-gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
> +        act-gpios = <&gpio0 17 GPIO_ACTIVE_LOW>;
> +    };