Re: [PATCH 3/6] platform: cznic: turris-omnia-mcu: replace use of system_wq with system_percpu_wq

[Marek Behún]

Acked-by: Marek Behún <kabel@xxxxxxxxxx>

On Tue, May 05, 2026 at 02:40:59PM +0200, Marco Crivellari wrote:
> Currently if a user enqueues a work item using schedule_delayed_work() the
> used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
> WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
> schedule_work() that is using system_wq and queue_work(), that makes use
> again of WORK_CPU_UNBOUND.
> 
> This lack of consistency cannot be addressed without refactoring the API.
> 
> This patch continues the effort to refactor worqueue APIs, which has begun
> with the change introducing new workqueues and a new alloc_workqueue flag:
> 
> commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
> commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
> 
> Replace system_wq with system_percpu_wq, keeping the same behavior.
> The old wq (system_wq) will be kept for a few release cycles.
> 
> Cc: Marek Behun <kabel@xxxxxxxxxx>
> Suggested-by: Tejun Heo <tj@xxxxxxxxxx>
> Signed-off-by: Marco Crivellari <marco.crivellari@xxxxxxxx>
> ---
>  drivers/platform/cznic/turris-omnia-mcu-gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/cznic/turris-omnia-mcu-gpio.c b/drivers/platform/cznic/turris-omnia-mcu-gpio.c
> index 7f0ada4fa606..4e430d6c3fc4 100644
> --- a/drivers/platform/cznic/turris-omnia-mcu-gpio.c
> +++ b/drivers/platform/cznic/turris-omnia-mcu-gpio.c
> @@ -893,7 +893,7 @@ static bool omnia_irq_read_pending_old(struct omnia_mcu *mcu,
>  
>  	if (status & OMNIA_STS_BUTTON_PRESSED) {
>  		mcu->button_pressed_emul = true;
> -		mod_delayed_work(system_wq, &mcu->button_release_emul_work,
> +		mod_delayed_work(system_percpu_wq, &mcu->button_release_emul_work,
>  				 msecs_to_jiffies(FRONT_BUTTON_RELEASE_DELAY_MS));
>  	} else if (mcu->button_pressed_emul) {
>  		status |= OMNIA_STS_BUTTON_PRESSED;
> -- 
> 2.53.0
>