Re: [PATCH 0/4] crypto: talitos - fix several issues in the Freescale talitos crypto driver

[Paul Louvel]

Upon reviewing Sashiko’s feedback this morning, some interesting reviews has 
been made.
Please disregard the current series and wait for a v2.

Thanks,
Paul.

On 5/4/26 5:38 PM, Paul Louvel wrote:
> This series fixes several issues in the Freescale talitos crypto driver.
>
> The first patch replaces the software workqueue approach introduced by
> commit 655ef638a2bc ("crypto: talitos - fix SEC1 32k ahash request
> limitation") to handle large requests. Depending on the SEC hardware
> version, replace this approach by using facilities provided by the
> hardware itself:
>
> - On SEC1, descriptors can be chained with the Next Descriptor field.
>
> - On SEC2, the per-channel fetch FIFO is used to submit multiple
>    descriptors.
>
> This removes the workqueue-based splitting entirely and fix the (64k -
> 1) byte ahash request limit on SEC2.
>
> Patches 2-3 are cleanups that follow the first patch: a field rename for
> clarity and folding a trivial wrapper function.
>
> Patch 4 fixes an off-by-one in the submit_count initialisation that
> wastes one FIFO slot.
>
> Tested on an MPC885 SoC (SEC1 Lite), and on an MPC8321EMP SoC (SEC2).
>
> Signed-off-by: Paul Louvel <paul.louvel@xxxxxxxxxxx>
> ---
> Paul Louvel (4):
>        crypto: talitos - use hardware facilities for large ahash requests
>        crypto: talitos - rename first_desc/last_desc to first_request/last_request
>        crypto: talitos - remove useless wrapper
>        crypto: talitos - fix invalid submit_count initial value
>
>   drivers/crypto/talitos.c | 583 +++++++++++++++++++++++++----------------------
>   drivers/crypto/talitos.h |  14 ++
>   2 files changed, 322 insertions(+), 275 deletions(-)
> ---
> base-commit: db8b9f227833e729faf44a512aa1e88a625b5ad8
> change-id: 20260504-bootlin_test-7-1-rc1_sec_bugfix-13169ed07ddc
>
> Best regards,
> --
> Paul Louvel <paul.louvel@xxxxxxxxxxx>
--
Paul Louvel, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com