Re: [PATCH v2] ALSA: hda/realtek: Add mute LED fixup for HP Pavilion 15-cs1xxx

[Takashi Iwai]

On Tue, 05 May 2026 17:42:28 +0200,
Rodrigo Faria wrote:
> 
> Add a new fixup for the mute LED on the HP Pavilion 15-cs1xxx series
> using the VREF on NID 0x1b.
> 
> The BIOS on these models (tested up to F.32) incorrectly reports
> the mute LED on NID 0x18 via DMI OEM strings, which lacks VREF
> capabilities. This fixup overrides the LED pin to the correct
> NID 0x1b.
> 
> Signed-off-by: Rodrigo Faria <rodrigofilipefaria@xxxxxxxxx>

It's almost fine, but ...

> +/* Override wrong pin to NID 0x1b (F.32 BIOS reports 0x18 via DMI OEM string)
> + * on HP pavilion 15-cs1xxx laptops */

Try to keep a comment in the standard coding style.
And...

> @@ -6907,6 +6926,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x103c, 0x8548, "HP EliteBook x360 830 G6", ALC285_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x854a, "HP EliteBook 830 G6", ALC285_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x85c6, "HP Pavilion x360 Convertible 14-dy1xxx", ALC295_FIXUP_HP_MUTE_LED_COEFBIT11),
> +	SND_PCI_QUIRK(0x103c, 0x856a, "HP Pavilion 15-cs1xxx", ALC295_FIXUP_HP_PAVILION_MUTE_LED_1B),
>  	SND_PCI_QUIRK(0x103c, 0x85de, "HP Envy x360 13-ar0xxx", ALC285_FIXUP_HP_ENVY_X360),
>  	SND_PCI_QUIRK(0x103c, 0x8603, "HP Omen 17-cb0xxx", ALC285_FIXUP_HP_MUTE_LED),
>  	SND_PCI_QUIRK(0x103c, 0x860c, "HP ZBook 17 G6", ALC285_FIXUP_HP_GPIO_AMP_INIT),

The entry is sorted in PCI SSID order.  Try to put at the right
position.


thanks,

Takashi