RE: [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010 10BASE-T1S MACPHY

[Selvamani Rajagopal]

> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: Tuesday, May 5, 2026 12:02 PM
> To: Selvamani Rajagopal <Selvamani.Rajagopal@xxxxxxxxxx>
> Cc: Rob Herring <robh@xxxxxxxxxx>; Piergiorgio Beruto <Pier.Beruto@xxxxxxxxxx>;
> andrew+netdev@xxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx;
> kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010
> 10BASE-T1S MACPHY
> 
> 
> This Message Is From an External Sender
> This message came from outside your organization.
> 
> > > Since it is a 10Mbps media, if the SPI speed is lower than 15MHz,
> > > maybe it cannot keep up with the media? But this clock speed on its
> > > own is not the deciding factor, there could be other users of the SPI
> > > bus. I would expect the driver and device to keep working if the SPI
> > > bus is saturated, just not give the full 10Mbps. And it would also be
> > > a good test the device and driver do work correctly when the bus is
> > > saturated.
> >
> >
> 
> > I should have given more information. If we configure SPI at lower
> > speed, it may start losing frames as it can't sustain the PHY's
> > speed. Please let me know If I should remove it.
> 
> So it is not really a requirement. Please add a comment that at speed
> of at least 15MHz is recommended in order to obtain line rate
> performance.

Will; do, along with changes to take care of other comments for the same file.
Thanks

> 
> Andrew