Re: [PATCH v1 1/7] rust: sync: completion: add wait_for_completion_timeout()
From: Joel Fernandes
Date: Tue May 05 2026 - 16:23:52 EST
On 5/5/2026 8:17 AM, Miguel Ojeda wrote:
> On Fri, May 1, 2026 at 10:58 PM Joel Fernandes <joelagnelf@xxxxxxxxxx> wrote:
>>
>> + // SAFETY: `self.as_raw()` is a pointer to a valid `struct completion`.
>
> This is fine since it follows the other ones in the file, but we
> should say why this is the case (in another series, possibly a good
> first issue), rather than just asserting it.
>
> e.g. a type invariant?
>
Sure, I will make this change as a separate patch. Probably if it is one extra
patch, I'll just add it to the series.
thanks,
--
Joel Fernandes