Re: [PATCH] irqchip: ath79: remove unused function

From: Rosen Penev

Date: Tue May 05 2026 - 18:33:08 EST


On Tue, May 5, 2026 at 12:43 PM Thomas Gleixner <tglx@xxxxxxxxxx> wrote:
>
> On Tue, May 05 2026 at 00:50, Rosen Penev wrote:
>
> Please use the proper subsystem prefix as documented:
>
> https://www.kernel.org/doc/html/latest/process/maintainer-tip.html
>
> > It seems ath79_cpu_irq_init was used a long time ago before the OF code
>
> It seems? Either it is or not.
>
> Also please find and describe the commit which removed the usage and
> failed to remove the function.
Ah hah. Found where it stopped being used:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=51fa4f8912c0934cf1410f435516d2abbcf88a9e

Found from https://lore.kernel.org/all/202412011509.kGQkDr1y-lkp@xxxxxxxxx/
which seems to have never been fixed.

Should I add a fixes tag?

A small note: this patch has been carried since the OF conversion of
this target downstream in OpenWrt but never upstreamed.
>
> Thanks,
>
> tglx