RE: [PATCH v2 0/4] iio: introduce devm_ API for hid sensro setup and cleanup
From: Zhang, Lixu
Date: Tue May 05 2026 - 21:51:32 EST
>-----Original Message-----
>From: Jonathan Cameron <jic23@xxxxxxxxxx>
>Sent: Wednesday, May 6, 2026 12:33 AM
>To: srinivas pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
>Cc: Sanjay Chitroda <sanjayembeddedse@xxxxxxxxx>; jikos@xxxxxxxxxx;
>Lechner, David <dlechner@xxxxxxxxxxxx>; nuno.sa@xxxxxxxxxx;
>andy@xxxxxxxxxx; sakari.ailus@xxxxxxxxxxxxxxx; linux-input@xxxxxxxxxxxxxxx;
>linux-iio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Zhang, Lixu
><lixu.zhang@xxxxxxxxx>
>Subject: Re: [PATCH v2 0/4] iio: introduce devm_ API for hid sensro setup and
>cleanup
>
>On Fri, 01 May 2026 04:53:38 -0700
>srinivas pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> wrote:
>
>> + Lixu
>>
>> On Wed, 2026-04-29 at 23:29 +0530, Sanjay Chitroda wrote:
>> > From: Sanjay Chitroda <sanjayembeddedse@xxxxxxxxx>
>> >
>> > Key highlights:
>> > - Prepare change as pre-requisite for devm conversion for HID IIO
>> > drivers by removing redundant argument
>> > - Add devm API to setup trigger and clenaup resource using
>> > devm_add_action_or_reset()
>> > - few sample driver update using devm conversion to auto release
>> > resource
>> >
>>
>> devm_* calls are fine but needs tests particularly when forces ISH PCI
>> drivers unbind, while iio-sensor-proxy has open sessions.
>>
>> Lixu, Please check.
>Hold off perhaps until we have a v3 with fixes for the existing devm calls against
>wrong struct device.
Sure, I'll test the ISH unbind scenario once v3 is out.
Thanks,
Lixu
>
>Thanks,
>
>Jonathan
>
>>
>> Thanks,
>> Srinivas
>>