Re: Re: [PATCH net-next v7 2/4] net: stmmac: eic7700: enable clocks before syscon access and correct RX sampling timing

From: 李志

Date: Tue May 05 2026 - 22:12:08 EST





> -----原始邮件-----
> 发件人: "Jakub Kicinski" <kuba@xxxxxxxxxx>
> 发送时间:2026-05-01 07:35:51 (星期五)
> 收件人: 李志 <lizhi2@xxxxxxxxxxxxxxxxxx>
> 抄送: andrew+netdev@xxxxxxx, devicetree@xxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, edumazet@xxxxxxxxxx, robh@xxxxxxxxxx, krzk+dt@xxxxxxxxxx, conor+dt@xxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, pabeni@xxxxxxxxxx, mcoquelin.stm32@xxxxxxxxx, alexandre.torgue@xxxxxxxxxxx, rmk+kernel@xxxxxxxxxxxxxxx, pjw@xxxxxxxxxx, palmer@xxxxxxxxxxx, aou@xxxxxxxxxxxxxxxxx, alex@xxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, maxime.chevallier@xxxxxxxxxxx, ningyu@xxxxxxxxxxxxxxxxxx, linmin@xxxxxxxxxxxxxxxxxx, pinkesh.vaghela@xxxxxxxxxxxxxx, pritesh.patel@xxxxxxxxxxxxxx, weishangjuan@xxxxxxxxxxxxxxxxxx, horms@xxxxxxxxxx
> 主题: Re: [PATCH net-next v7 2/4] net: stmmac: eic7700: enable clocks before syscon access and correct RX sampling timing
>
> On Thu, 30 Apr 2026 14:43:50 +0800 (GMT+08:00) 李志 wrote:
> > > Why Fixes? If eth1 never worked this is not a fix but new functionality
> > > If you want to make this a fix to prevent incompatibility - cut it down
> > > just to the eth0 changes.
> > >
> > Thank you for the suggestion.
> >
> > You're right that eth1 never worked at Gigabit speed, so this should
> > not be treated as a fix.
> >
> > In v8, I will split the changes into two patches within the same series:
> > - Patch 1 will contain only the fixes affecting the existing eth0
> > functionality, and will keep the Fixes tag.
> > - Patch 2 will add the eth1 support (RX clock inversion workaround)
> > as new functionality, without a Fixes tag.
> >
> > Please let me know if you would prefer a different split or ordering.
>
> If you want to consider some part of this commit a fix it has to be
> posted separately to the net tree (rather than net-next).
> Once it's merged and makes it way over to the net-next tree (each
> Thursday) you can post the net-next chnages for eth1

Thanks, understood.

I will split the changes accordingly:
- Send the eth0 fixes as a new v1 series targeting net.
- Send the eth1 enablement as a new v1 series targeting net-next.

Thanks for the guidance.