Re: [PATCH] staging: rtl8723bs: fix open parenthesis at end of line

From: gregkh@xxxxxxxxxxxxxxxxxxx

Date: Wed May 06 2026 - 01:01:26 EST


On Wed, May 06, 2026 at 02:26:02AM +0000, David Cardenas wrote:
> Function declarations and conditional statements should not end
> with an opening parenthesis. Reformat affected functions and
> if statements to place the opening condition or first parameter
> on the same line as the function name or keyword
>
> Signed-off-by: David <ldcc@xxxxxxxxx>
> ---
> .../staging/rtl8723bs/hal/HalPhyRf_8723B.c | 179 +++++++-----------
> 1 file changed, 64 insertions(+), 115 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> index 6ab65e9e8..59b8f7e99 100644
> --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> @@ -30,6 +30,7 @@ static u8 DeltaSwingTableIdx_2GA_N_8188E[] = {
> 0, 0, 0, 2, 2, 3, 3, 4, 4, 4, 4, 5, 5, 6, 6,
> 7, 7, 7, 7, 8, 8, 9, 9, 10, 10, 10, 11, 11, 11, 11
> };
> +

This change is not described in your changelog :(

Also, the From: line does not match your Signed-off-by: line.

thanks,

greg k-h