Re: [PATCH net v7 1/2] ipv6: flowlabel: take ip6_fl_lock across mem_check and fl_intern

[Maoyi Xie]

Hi Willem,

Thanks for the review on both, and for the Reviewed-by tags.

>> Signed-off-by: Maoyi Xie <maoyi.xie@xxxxxxxxxx>
> Please update either your git config name or Signed-off-by to
> make sure that the two are the same.

Sorry for the noise. We sent the series through Gmail because
our NTU SMTP does not accept git send-email, and Gmail rewrote
the From header of the resulting mail. v8 will set the email
header From to the Gmail address and inject an in-body From: line
with the NTU address, so the trailer matches the author.

>> +/* Caller must hold ip6_fl_lock. */
> nit: lockdep_assert_held as used below is preferable over
> comments

Will replace the comment with lockdep_assert_held(&ip6_fl_lock)
at the top of fl_intern() in v8.

> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

Will add the same Fixes trailer to 1/2 in v8.

We will respin as v8 after the 24h netdev window.

Maoyi
Nanyang Technological University
https://maoyixie.com/