Re: [PATCH v3] staging: rtl8723bs: remove unnecessary comparison to true

[gregkh]

On Wed, May 06, 2026 at 11:51:37AM +0530, Ashwin Gundarapu wrote:
> On Wed, May 06, 2026 at 10:33:02AM +0530, Ashwin Gundarapu wrote:
> > Remove explicit comparison to true in check_fwstate() call and
> > add spacing around the bitwise OR operator to improve code style.
> >
> > Signed-off-by: Ashwin Gundarapu <linuxuser509@xxxxxxxxxxx>
> > ---
> > v3: Fixed double --- line and corrected whitespace formatting as
> > requested by Greg KH.
> 
> Changes from v1:
> - v2: Resent with corrected whitespace via Thunderbird plain text mode
> - v3: Fixed double --- line and corrected whitespace formatting
> 
> The original v1 was sent from Gmail web client which corrupted tabs
> to spaces. v2 attempted Thunderbird plain text. v3 fixes the double
> --- separator and uses Zoho webmail plain text which preserved tabs.

This all needs to go below the --- line.

Please add it to v4 when you resend that in a day or so.

Also realize you did not run your patch through checkpatch to verify
that you did not add any issues with your change :(

thanks,

greg k-h