Re: [PATCH v5 14/18] iio: magnetometer: ak8975: switch to using managed resources
From: Andy Shevchenko
Date: Wed May 06 2026 - 04:25:52 EST
On Tue, May 05, 2026 at 04:34:29PM +0200, Joshua Crofts wrote:
> On Tue, 5 May 2026 at 13:46, Joshua Crofts via B4 Relay
> <devnull+joshua.crofts1.gmail.com@xxxxxxxxxx> wrote:
> >
> > Switch the driver to use managed resources (devm_*) which simplifier
> > error handling and allows removing ak8975_remove() method from
> > the driver.
> >
> > Note, on error path we now also set mode to POWER_DOWN state which is
> > fine. Even if the device is in that mode, there is no problem to set
> > that mode again, it should be no-op.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Co-developed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
> > Signed-off-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
>
> BTW, Sashiko timed out while reviewing this patch, didn't even know that's
> possible.
You can ask Roman what to do in such a case.
--
With Best Regards,
Andy Shevchenko