Re: [PATCH v3] iio: humidity: ens210: Fix missing I2C functionality checks

[Andy Shevchenko]

On Tue, May 05, 2026 at 06:49:43PM +0100, Salah Triki wrote:
> The ENS210 driver uses SMBus transactions (such as byte, word, and block
> data reads/writes) during the probe and measurement phases. However, the
> initial functionality check only validated a subset of these capabilities,
> which could lead to loading failures on adapters requiring SMBus
> emulation or native-only controllers.
> 
> To ensure compatibility across a wide range of I2C adapters, modify the
> functionality check to verify if the adapter supports the required native
> operations or, failing that, supports the SMBus emulation layer.

...

> ---
> Changes since v2:
> - Fixed the alignment and indentation of the I2C functionality check
>   per Maxime's review.

???

...

>  	if (!i2c_check_functionality(client->adapter,
> -				     I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
> -				     I2C_FUNC_SMBUS_WRITE_BYTE |
> -				     I2C_FUNC_SMBUS_READ_I2C_BLOCK)) {
> +				I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
> +				I2C_FUNC_SMBUS_WRITE_BYTE |
> +				I2C_FUNC_SMBUS_READ_BYTE_DATA |
> +				I2C_FUNC_SMBUS_READ_WORD_DATA |
> +				I2C_FUNC_SMBUS_READ_I2C_BLOCK) &&

The above was the correct one.

> +				!i2c_check_functionality(client->adapter,
> +					I2C_FUNC_SMBUS_EMUL)) {

This one is now wrong.


-- 
With Best Regards,
Andy Shevchenko