Re: [PATCH v2 1/1] rust: drm: add RENDER_CAPABILITY flag for render node support

[Laura Nao]

Hi Alice,

On 5/5/26 12:54, Alice Ryhl wrote:
>
> I think it would be nice for this documentation to elaborate more on
> what this feature actually does. After all, it clearly took us a while
> to understand it, so probably others are confused too.
>
> Something along these lines:
>
> /// Sets the `DRIVER_RENDER` feature for this driver.
> /// 
> /// When enabled, the driver exposes `/dev/dri/renderDXX` render nodes to
> /// userspace. The render node is an alternate low-priviledge way to access
> /// the driver, which is enforced on a per-ioctl level. Userspace processes
> /// that open the render node can only invoke ioctls explicitly listed as
> /// usable from the render node, whereas userspace processes using the
> /// master node can invoke any ioctl.
> const RENDER_CAPABILITY: bool = false;
>

Agreed, the extra documentation will definitely help clarify the flag 
purpose. Thanks for the feedback!

> Also, I'd probably call this const `FEAT_RENDER` for consistency / to
> make it show up in grep.
>

Right, using FEAT_RENDER in the Driver trait as well sounds good to me.
I'll submit a new revision with these changes.

Best,

Laura