Re: [PATCH v2] iio: humidity: ens210: Fix missing I2C functionality checks

[Andy Shevchenko]

On Tue, May 05, 2026 at 12:33:36PM -0500, Maxwell Doose wrote:
> On Tue May 5, 2026 at 12:22 PM CDT, Salah Triki wrote:

> [snip]

> >  	if (!i2c_check_functionality(client->adapter,
> > -				     I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
> > -				     I2C_FUNC_SMBUS_WRITE_BYTE |
> > -				     I2C_FUNC_SMBUS_READ_I2C_BLOCK)) {
> > +				I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
> > +				I2C_FUNC_SMBUS_WRITE_BYTE |
> > +				I2C_FUNC_SMBUS_READ_BYTE_DATA |
> > +				I2C_FUNC_SMBUS_READ_WORD_DATA |
> > +				I2C_FUNC_SMBUS_READ_I2C_BLOCK) &&
> > +			!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_EMUL)) {
> >  		return dev_err_probe(&client->dev, -EOPNOTSUPP,
> >  			"adapter does not support some i2c transactions\n");
> >  	}
> 
> This alignment doesn't look right. Probably should be something like:

However the end result is wrong, this one...

>   	if (!i2c_check_functionality(client->adapter,
> 				     I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
> 				     I2C_FUNC_SMBUS_WRITE_BYTE |
> 				     I2C_FUNC_SMBUS_READ_BYTE_DATA |
> 				     I2C_FUNC_SMBUS_READ_WORD_DATA |
> 				     I2C_FUNC_SMBUS_READ_I2C_BLOCK) &&
>  			             !i2c_check_functionality(client->adapter, 
> 							      I2C_FUNC_SMBUS_EMUL)) {

...is also wrong.

if (!i2c_check_functionality(client->adapter,
			     I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
			     I2C_FUNC_SMBUS_WRITE_BYTE |
			     I2C_FUNC_SMBUS_READ_BYTE_DATA |
			     I2C_FUNC_SMBUS_READ_WORD_DATA |
			     I2C_FUNC_SMBUS_READ_I2C_BLOCK) &&
    !i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_EMUL)) {

-- 
With Best Regards,
Andy Shevchenko