Re: [PATCH v3 09/15] clk: rp1: use clk_determine_rate_noop()

[Andrea della Porta]

Hi Brian,

On 20:49 Tue 05 May     , Brian Masney wrote:
> Drop the driver-specific empty determine_rate() function and use the new
> shared clk_determine_rate_noop() helper.
> 
> Signed-off-by: Brian Masney <bmasney@xxxxxxxxxx>
> ---
> To: Andrea della Porta <andrea.porta@xxxxxxxx>
> To: Michael Turquette <mturquette@xxxxxxxxxxxx>
> To: Stephen Boyd <sboyd@xxxxxxxxxx>
> Cc: Brian Masney <bmasney@xxxxxxxxxx>
> Cc: linux-clk@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> ---
>  drivers/clk/clk-rp1.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/clk/clk-rp1.c b/drivers/clk/clk-rp1.c
> index fd144755b879..0f7d9fd77481 100644
> --- a/drivers/clk/clk-rp1.c
> +++ b/drivers/clk/clk-rp1.c
> @@ -1174,12 +1174,6 @@ static unsigned long rp1_varsrc_recalc_rate(struct clk_hw *hw,
>  	return clock->cached_rate;
>  }
>  
> -static int rp1_varsrc_determine_rate(struct clk_hw *hw,
> -				     struct clk_rate_request *req)
> -{
> -	return 0;
> -}
> -
>  static const struct clk_ops rp1_pll_core_ops = {
>  	.is_prepared = rp1_pll_core_is_on,
>  	.prepare = rp1_pll_core_on,
> @@ -1227,7 +1221,7 @@ static const struct clk_ops rp1_clk_ops = {
>  static const struct clk_ops rp1_varsrc_ops = {
>  	.set_rate = rp1_varsrc_set_rate,
>  	.recalc_rate = rp1_varsrc_recalc_rate,
> -	.determine_rate = rp1_varsrc_determine_rate,
> +	.determine_rate = clk_determine_rate_noop,
>  };
>  
>  static struct clk_hw *rp1_register_pll(struct rp1_clockman *clockman,
> 
> -- 
> 2.54.0
>

Reviewed-by: Andrea della Porta <andrea.porta@xxxxxxxx>

Thanks!