Re: [PATCH] platform/x86: asus-armoury: downgrade missing power limits warning to debug

[Ilpo Järvinen]

On Mon, 4 May 2026, Denis Benato wrote:
> On 5/3/26 19:57, Armandas Kvietkus wrote:
> > When a system is not found in the power_limits DMI table,
> > init_rog_tunables() emits a pr_warn() and returns. This is
> > expected behaviour for hardware that does not support ROG
> > power limit tunables, not an error condition.
> >
> > Downgrade to pr_debug() to avoid spurious boot noise on
> > unsupported systems while preserving the message for debugging.
> >
> > Reported-by: fxzxaxon@xxxxxxxxxxx
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221441
> > Signed-off-by: Armandas Kvietkus <armundunelis@xxxxxxxxx>
> > ---
> >  drivers/platform/x86/asus-armoury.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
> > index 5b0987ccc..c8e9ff89f 100644
> > --- a/drivers/platform/x86/asus-armoury.c
> > +++ b/drivers/platform/x86/asus-armoury.c
> > @@ -991,7 +991,7 @@ static void init_rog_tunables(void)
> >  	/* Match the system against the power_limits table */
> >  	dmi_id = dmi_first_match(power_limits);
> >  	if (!dmi_id) {
> > -		pr_warn("No matching power limits found for this system\n");
> > +		pr_debug("No matching power limits found for this system\n");
>
> Maybe this is right to get downgraded, but still no debug: I think info is better,
> but I would like to hear from Luke what this is about.

Hi Denis,

When kernel is built with CONFIG_DYNAMIC_DEBUG=y, all debug messages 
will appear if kernel's cmdline enables it:

dyndbg="file drivers/platform/x86/asus-armoury.c +p"

(wildcards too could be used where helpful and semicolon as a separator 
if, in rare cases, more than one filter should be necessary).

So all we need is to ask the reporter to boot with dyndbg enabled for the 
relevant file(s), no recompiling the kernel required.


I suspect most distros do have dynamic debugging capability in their 
kernel configs so it shouldn't be a problem when they don't by default 
show these messages (at least the two major ones I just checked have it).


-- 
 i.