Re: [PATCH v4] ASoC: tegra: Add per-stream Mixer Fade controls

[Mark Brown]

On Wed, May 06, 2026 at 10:20:32AM +0000, Sheetal wrote:
> Add per-stream fade controls for the Tegra mixer to allow
> independently configuring target gain and fade duration for each of
> the 10 input streams (RX1 through RX10).

> +			else if (i == DURATION_INV_N3_ID)
> +				val = (u32)(BIT_ULL(31 + TEGRA210_MIXER_PRESCALAR) /
> +					    mixer->duration[id]);
> +			else

I'll apply this but there's one small issue which can be addressed
incrementally: if the duration is very small (32 or less) then we'll
overflow the u32 and generate nonsense values.  Either constraining the
minimum or doing the maths with a 64 bit value would avoid the issue.

Attachment: signature.asc
Description: PGP signature