Re: [PATCH] EDAC/mce_amd: Fix Hygon UMC ECC error decoding with logical_die_id

[Aichun Shi]

On 5/5/2026 1:55 AM, Borislav Petkov wrote:
> On Sun, Mar 01, 2026 at 10:26:09PM +0800, Aichun Shi wrote:
> > You are right, the family check (0x18) is over restrictive and can be removed.
>
> How much of sprinking of "if Hygon" is this file going to get? If you start
> sprinkling it left and right I'd prefer if you did drivers/edac/mce_hygon.c
> and add the functionality you need, without impairing AMD code and us not
> being able to change it due to Hygon-specific changes which we cannot test
> anyway...
>
> Thx.

Hi Boris,
   Thanks for your guidance. From what I can see, this is the only spot 
where we need to sprinkle an "if Hygon" check to enable error decoding 
in mce_amd.c for Hygon platforms.If any other similar checks are 
required in the future, I will move them into mce_hygon.c.

Best Regards,
Aichun