Re: [PATCH v12 04/22] gpu: nova-core: mm: Add support to use PRAMIN windows to write to VRAM
From: Joel Fernandes
Date: Wed May 06 2026 - 10:52:12 EST
On 5/5/2026 8:47 PM, Alexandre Courbot wrote:
> On Wed May 6, 2026 at 7:59 AM JST, Joel Fernandes wrote:
>>
>>
>>> On May 2, 2026, at 11:42 AM, Alexandre Courbot <acourbot@xxxxxxxxxx>
>>
>>>> +
>>>> +/// PRAMIN aperture manager.
>>>> +///
>>>> +/// Call [`Pramin::get_window()`] to acquire exclusive PRAMIN access.
>>>> +#[pin_data]
>>>> +pub(crate) struct Pramin {
>>>> + bar: Arc<Devres<Bar0>>,
>>>
>>> The HRT series [1] will allow you to greatly simplify all this by
>>> storing a `&'a Bar0` directly in this structure. It will most likely
>>> land this cycle, so I think it's a good idea to proactively depend on
>>> them. It should apply cleanly (modulo the Tyr patches IIRC, but you can
>>> skip them if you don't build the driver) on top of `drm-rust-next` - on
>>> top of which this should also be rebased anyway.
>>>
>>> [1] https://lore.kernel.org/all/20260427221155.2144848-1-dakr@xxxxxxxxxx/
>>>
>>
>> I tried to apply it but had a lot of conflict.
>>
>> Danilo, do you have a tree of these patches somewhere that applies on drm-rust-next?
>
> I have a tree here, it should build fine as long as Tyr is not enabled:
>
> https://github.com/Gnurou/linux/tree/drm-rust-next-hrt
Thank you Alex, I will give this a try.