Re: [PATCH net-next 10/12] net: stmmac: tc956x: add TC956x/QPS615 support

[Xilin Wu]

On 5/6/2026 10:45 PM, Andrew Lunn wrote:
> > Hi Andrew,
> >
> > Yes, the PHY is doing the WoL. And I guess this makes sense as it allows the
> > MAC to power down during suspend to save power.
> >
> > The INTN pin of QCA8081 is connected to the ETH_0_INT_N of QPS615. And the
> > INTN_WOL pin is connected to a SoC GPIO.
> >
> > Without this change, I can't get WoL to work. I have a working branch for
> > our board here:
> > https://github.com/strongtz/linux-radxa-qcom/commits/v7.0.2-8280-wip/
>
> Please take a look at commit
>
> commit 6911308d7d111a9c367293b52f2dc265819f2b60
> Author: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>
> Date:   Thu Oct 23 10:16:50 2025 +0100
>
>      net: stmmac: convert to phylink-managed Wake-on-Lan
>
> In particular:
>
>      When STMMAC_FLAG_USE_PHY_WOL is not set, we provide the MAC's WoL
>      capabilities to phylink, which then allows phylink to choose between
>      the PHY and MAC for WoL depending on their individual capabilities
>      as described in the phylink commit. This only augments the WoL
>      functionality with PHYs that declare to the driver model that they are
>      wake-up capable. Currently, very few PHY drivers support this.
>      
> Could you actually patch the PHY driver to make it list its
> capabilities. That is the direction we want to go in the long term,
> and not use STMMAC_FLAG_USE_PHY_WOL.
>
>      Andrew

Thanks for pointing this out! You are right that I should patch the PHY 
driver. I have made WoL work without the change in the tc956x driver.

--
Best regards,
Xilin Wu <sophon@xxxxxxxxx>